Eric proj4 #5
Eric proj4 #5
Conversation
| @Override | ||
| public void onClick(View v){ | ||
| switch (v.getId()) { | ||
| case R.id.createEventButton: |
There was a problem hiding this comment.
Code in each case in this switch statement could be modularized into functions to make it easier to read. Like you could have createEventButtonClicked()
| break; | ||
| default: | ||
| } | ||
| } |
There was a problem hiding this comment.
I usually see onCreate at the top of the class. Idk how other people feel about it but that's what I've seen the most.
| protected void onActivityResult(int requestCode, int resultCode, Intent data) { | ||
| super.onActivityResult(requestCode, resultCode, data); | ||
| //Detects request codes | ||
| if ((requestCode == 3 || requestCode == 1) && resultCode == Activity.RESULT_OK) { |
There was a problem hiding this comment.
What do 3 and 1 represent? Define them as public static final ints at the top so we know what request each corresponds to. In the 61B style guide, these are referred to as "magic numbers"
| @Override | ||
| public void onClick(View v){ // Handles Cases for clicking Interested & Num RSVP Buttons | ||
| switch (v.getId()) { | ||
| case R.id.numRSVPButton: |
There was a problem hiding this comment.
Code in each case in this switch statement could be modularized into functions to make it easier to read. Like you could have numRSVPButtonClicked(), interestedButtonClicked(), etc
| mSocials.clear(); | ||
| for (DataSnapshot socialSnapShot: dataSnapshot.getChildren()) { | ||
| GenericTypeIndicator<ArrayList<String>> t = new GenericTypeIndicator<ArrayList<String>>() {}; | ||
| Social social = new Social(socialSnapShot.child(getString(R.string.eventName)).getValue(String.class), |
There was a problem hiding this comment.
You can give Firebase enter classes, like snapshot.getValue(Social.class) and it'll populate the fields based on the variable names. It is useful in cases like this.
| } | ||
| } | ||
|
|
||
| protected void onProgressUpdate(Void... progress) {} |
There was a problem hiding this comment.
If this function isn't used then don't include it.
| new DownloadFilesTaskSocial().execute(uri.toString()); | ||
|
|
||
| } | ||
| }).addOnFailureListener(new OnFailureListener() { |
There was a problem hiding this comment.
Is there a need for this failure listener? If it isn't used?
| public void onClick(View view) { | ||
| Intent intent = new Intent(context, DetailActivity.class); | ||
| String socialId = s.eventImage.substring(0, s.eventImage.length() - 4); | ||
| intent.putExtra("socialID", socialId); |
There was a problem hiding this comment.
You can define the strings used as the extra keys as final variables at the top of the class to prevent typos (because you'll be using these same strings again when extracting the extras)
Fix